Skip to content

new tenant instead of add account - #13981

Merged
RosiKyu merged 1 commit into
mainfrom
ghi13975-add-account-ux
Nov 12, 2026
Merged

RosiKyu merged 1 commit into
mainfrom
ghi13975-add-account-ux

Conversation

@DaanHoogland

@DaanHoogland DaanHoogland commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor

Description

Operators often use "Add Account" when they mean to add a user to an existing account, and end up creating a new, isolated tenant. This PR makes the difference clear in the UI:

  • The account list action is now labelled Add Tenant Account, matching Add LDAP Account.
  • The Add Account dialog shows a warning: a new account is a separate tenant with its own limits and isolated resources, and users are added to an existing account with Add User.
  • New Add User action in an account's details view (Admin and DomainAdmin, enabled accounts only). It opens the Add User form with the account and domain filled in, and keeps them in sync when the form is reopened for another account.
  • The existing message.api.not.available translation is left unchanged; the warning has its own key.

Fixes: #13975

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

How Has This Been Tested?

🤖 Generated with Claude Code

@DaanHoogland DaanHoogland added this to the 24.0.0 milestone Aug 26, 2026
@DaanHoogland

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@DaanHoogland
DaanHoogland requested review from NuxRo and ingox August 26, 2026 12:50
@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov

codecov Bot commented Aug 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.77%. Comparing base (2d886b6) to head (3224613).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #13981   +/-   ##
=========================================
  Coverage     20.77%   20.77%           
- Complexity    21923    21927    +4     
=========================================
  Files          6496     6496           
  Lines        591630   591636    +6     
  Branches      72591    72592    +1     
=========================================
+ Hits         122914   122925   +11     
+ Misses       455372   455367    -5     
  Partials      13344    13344           
Flag Coverage Δ
uitests 3.88% <ø> (-0.01%) ⬇️
unittests 22.08% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13981 (QA-JID-983)

@github-actions

github-actions Bot commented Aug 26, 2026 •

Copy link
Copy Markdown

🔴 Test Coverage Grade: D — Marginal

Metric Value
Line coverage 25.88%
Branch coverage 20.22%

Grade Scale

Grade Line Coverage Meaning
🟢 A ≥ 80% Excellent - this code sleeps well at night 😴
🟡 B 60-79% Good - almost there, don't stop now 😉
🟠 C 40-59% Acceptable - your code is wearing a seatbelt, but no airbags 😬
🔴 D 20-39% Marginal - boldly shipping where no test has gone before 🖖
⛔ F < 20% Failing - tests? what tests? 🔥

Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run

@daviftorres

Copy link
Copy Markdown
Contributor

Dear @DaanHoogland,

Thank you for taking this nomenclature issue seriously and working on a fix. This is also a constant source of confusion in our organization.

Regarding ACS's use of the word "Account," you recently labeled it "New Tenant Account." While this is an improvement, it may still cause some confusion.

Have you considered using "Department" or "Organizational Unit" instead?

Regards,

@ingox

ingox commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

@daviftorres I agree with your recommendations in the scope of a corporate organization.

But think of a public cloud where each account could represent a single user. AWS also names it accounts. So maybe renaming is not needed. Just decouple accounts from users and don't have them in the same dialog.

@ingox

ingox commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

@DaanHoogland a few thoughts and observations:

  • the add user button does not have any text in it
  • now we have "NEW" Tenant Account and "ADD" LDAP Account - that should be named the same
  • I'd prefer to remove the user creation from the account creation page. If that is not possible because the first user has to be created we may split that into two areas where the first one does focus on the account and the second one will cover the creation of the FIRST user in the account

@davift

davift commented Aug 27, 2026

Copy link
Copy Markdown

@daviftorres I agree with your recommendations in the scope of a corporate organization.

But think of a public cloud where each account could represent a single user. AWS also names it accounts. So maybe renaming is not needed. Just decouple accounts from users and don't have them in the same dialog.

I see your point and makes sense. But I guess there is no size fits all for this case. And the word "account" is misleading. I am fine with what ever @DaanHoogland decide, but I still think we should diverge the attention of the administrator to the user creation page.

@DaanHoogland

Copy link
Copy Markdown
Contributor Author

@luganofer closed his issue and I am not sure how to continue. He raised a serious design issue which is not in line with the UI fix I am creating here. How do you think we should continue, @ingox @davift ?

@luganofer

Copy link
Copy Markdown

@luganofer closed his issue and I am not sure how to continue. He raised a serious design issue which is not in line with the UI fix I am creating here. How do you think we should continue, @ingox @davift ?

Sorry for the confusion – I closed the issue accidentally while trying to reply. It's reopened now.

@DaanHoogland DaanHoogland moved this from Backlog to conflict/waiting in CloudStack Testing Aug 31, 2026
@kiranchavala

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19159

@kiranchavala kiranchavala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DaanHoogland

The add user icon is not clearly visible

Image Image

@github-actions

Copy link
Copy Markdown

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

Copilot AI lite review requested due to automatic review settings September 24, 2026 11:52
@DaanHoogland

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

A critical active finding remains because reused AddUser state can retain and apply a previous account or domain when creating a user without new context.

No open issues 🎉

1 previously missed issue

In code that hasn't changed since last review

High severity Reset stale account and domain values when reopening AddUser

ui/​src/​views/​iam/​AddUser.vue:275

AddUser is kept alive by AutogenView, so this method can run again after the same form was opened from an account detail. When it is then opened from the general user list (with no account/domain query), only the component-level account and domainid are reset; form.account and form.domainid still contain the previous account's values. Because createUser() falls back to those raw form values, the next user can silently be created in the previously selected account. Clear the form fields whenever the context is recomputed (including the no-context case).

1 resolved since last review

Review effort: Lite

@DaanHoogland
DaanHoogland force-pushed the ghi13975-add-account-ux branch from 5ae9287 to 3224613 Compare November 5, 2026 13:59
Copilot AI lite review requested due to automatic review settings November 5, 2026 13:59
@DaanHoogland

Copy link
Copy Markdown
Contributor Author

@kiranchavala @ingox @davift , please have a fresh look.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain requiring resolution, so the changes are ready for approval.

No open issues 🎉

Review effort: Lite

@sonarqubecloud

sonarqubecloud Bot commented Nov 5, 2026

Copy link
Copy Markdown

@nvazquez

nvazquez commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13981 (QA-JID-1014)

@nvazquez nvazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvazquez

nvazquez commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

@kiranchavala @ingox @davift can you please review the latest changes?

@blueorangutan

Copy link
Copy Markdown

Packaging result [LL]: ✖️ el7 ✔️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 6223

@Pearl1594

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19987

@ingox ingox left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement. Looks good to me.

@RosiKyu

RosiKyu commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@RosiKyu a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@RosiKyu

RosiKyu commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@RosiKyu a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13981 (QA-JID-1016)

@RosiKyu RosiKyu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested the UI build (https://qa.cloudstack.cloud/simulator/pr/13981) as root admin:

  • Accounts list: the action now reads "Add Tenant Account".
  • The Add Tenant Account dialog shows the warning that a new account is a separate tenant, pointing to "Add User".
  • Account details view: new "Add User" action; the form opens with account and domain filled in (fields hidden).
  • Submitted it: the new user was created in the selected existing account (account user, domain ROOT), no new account created.
  • No regression: "Add User" on the Users list still asks for Domain and Account, and the account is not prefilled from the listed user.

@RosiKyu
RosiKyu merged commit 6019b89 into main Nov 12, 2026
30 checks passed
@github-project-automation github-project-automation Bot moved this from conflict/waiting to Done in CloudStack Testing Nov 12, 2026
@DaanHoogland
DaanHoogland deleted the ghi13975-add-account-ux branch November 12, 2026 09:38
@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-17554)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 63866 seconds
Marvin logs: not retained - PR was already closed when the run finished
Smoke tests completed. 157 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

[UI] "Add Account" form misleads users into creating unintended multi‑account tenants instead of adding users